linux-kernel - Re: [PATCH v4 1/6] dt-bindings: ap806: add the cluster clock node in the syscon file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Mar 2019 12:39:24 -0500
From:   Rob Herring <robh@...nel.org>
To:     Gregory CLEMENT <gregory.clement@...tlin.com>
Cc:     Stephen Boyd <sboyd@...eaurora.org>,
        Mike Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Jason Cooper <jason@...edaemon.net>,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        linux-arm-kernel@...ts.infradead.org,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        Miquèl Raynal <miquel.raynal@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH v4 1/6] dt-bindings: ap806: add the cluster clock node in
 the syscon file

On Thu, Mar 28, 2019 at 06:25:14PM +0100, Gregory CLEMENT wrote:
> Hi Rob,
>  
>  On jeu., mars 28 2019, Rob Herring <robh@...nel.org> wrote:
> 
> > On Mon, Mar 25, 2019 at 01:47:58PM +0100, Gregory CLEMENT wrote:
> >> Document the device tree binding for the cluster clock controllers found
> >> in the Armada 7K/8K SoCs.
> >> 
> >> Signed-off-by: Gregory CLEMENT <gregory.clement@...tlin.com>
> >> ---
> >>  .../arm/marvell/ap806-system-controller.txt   | 25 +++++++++++++++++++
> >>  1 file changed, 25 insertions(+)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt
> >> index 7b8b8eb0191f..ceeba18b4ac3 100644
> >> --- a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt
> >> +++ b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt
> >> @@ -143,3 +143,28 @@ ap_syscon1: system-controller@...000 {
> >>  		#thermal-sensor-cells = <1>;
> >>  	};
> >>  };
> >> +
> >> +Cluster clocks:
> >> +---------------
> >> +
> >> +Device Tree Clock bindings for cluster clock of AP806 Marvell. Each
> >> +cluster contain up to 2 CPUs running at the same frequency.
> >> +
> >> +Required properties:
> >> +- compatible: must be  "marvell,ap806-cpu-clock";
> >> +- #clock-cells : should be set to 1.
> >> +- clocks : shall be the input parents clock phandle for the clock.
> >> +
> >> +Optional property:
> >> + - reg: register range associated the cluser clocks
> >
> > reg can be optional to use, but should either be there or not.
> 
> OK so let's remove it!

If you can define what the registers are, then you should have it even 
if Linux happens to not care.

Rob