linux-kernel - Re: [PATCH] MIPS: SGI-IP27: Fix use of unchecked pointer in shutdown_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY4PR2201MB12724CF36EA5944BF43631F3C1590@CY4PR2201MB1272.namprd22.prod.outlook.com>
Date:   Thu, 28 Mar 2019 18:37:56 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Thomas Bogendoerfer <tbogendoerfer@...e.de>
CC:     Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <pburton@...ecomp.com>,
        James Hogan <jhogan@...nel.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH] MIPS: SGI-IP27: Fix use of unchecked pointer in
  shutdown_bridge_irq

Hello,

Thomas Bogendoerfer wrote:
> smatch complaint:
> 
> arch/mips/sgi-ip27/ip27-irq.c:123 shutdown_bridge_irq()
> warn: variable dereferenced before check 'hd' (see line 121)
> 
> Fix it by removing local variable and use hd->pin directly.
> 
> Fixes: 69a07a41d908 ("MIPS: SGI-IP27: rework HUB interrupts")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>
> Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Applied to mips-fixes.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@...s.com to report it. ]