linux-kernel - RE: [PATCH hyperv-fixes,v2] hv_netvsc: Fix unwanted wakeup after tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Mar 2019 19:27:39 +0000
From:   Haiyang Zhang <haiyangz@...rosoft.com>
To:     David Miller <davem@...emloft.net>
CC:     "sashal@...nel.org" <sashal@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "olaf@...fle.de" <olaf@...fle.de>, vkuznets <vkuznets@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH hyperv-fixes,v2] hv_netvsc: Fix unwanted wakeup after
 tx_disable



> -----Original Message-----
> From: linux-hyperv-owner@...r.kernel.org <linux-hyperv-
> owner@...r.kernel.org> On Behalf Of David Miller
> Sent: Thursday, March 28, 2019 3:22 PM
> To: haiyangz@...uxonhyperv.com
> Cc: sashal@...nel.org; linux-hyperv@...r.kernel.org; Haiyang Zhang
> <haiyangz@...rosoft.com>; KY Srinivasan <kys@...rosoft.com>; Stephen
> Hemminger <sthemmin@...rosoft.com>; olaf@...fle.de; vkuznets
> <vkuznets@...hat.com>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH hyperv-fixes,v2] hv_netvsc: Fix unwanted wakeup after
> tx_disable
> 
> From: Haiyang Zhang <haiyangz@...uxonhyperv.com>
> Date: Thu, 28 Mar 2019 19:16:37 +0000
> 
> > From: Haiyang Zhang <haiyangz@...rosoft.com>
> >
> > After queue stopped, the wakeup mechanism may wake it up again when
> > ring buffer usage is lower than a threshold. This may cause send path
> > panic on NULL pointer when we stopped all tx queues in netvsc_detach
> > and start removing the netvsc device.
> >
> > This patch fix it by adding a tx_disable flag to prevent unwanted
> > queue wakeup.
> >
> > Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
> > Reported-by: Mohammed Gamal <mgamal@...hat.com>
> > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> 
> Still need to fix the inline issues I mentioned in v1.

I will fix the inline issues. 

The haiyangz@...uxonhyperv.com cannot receive emails. 
My regular email is in the reply-to: field. 
Also, linuxonhyperv.com is being replaced by a new system soon.

Thanks.
- Haiyang