linux-kernel - Re: [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190329024449.GM12513@dragon>
Date:   Fri, 29 Mar 2019 10:44:50 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Thierry Reding <treding@...dia.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Johan Hovold <johan@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS

On Tue, Mar 26, 2019 at 05:26:53PM +0100, Jonathan Neuschäfer wrote:
> Hi, thanks for your comments. I'll address them in v2.
> 
> On Fri, Mar 22, 2019 at 09:31:53AM +0800, Shawn Guo wrote:
> > On Tue, Mar 19, 2019 at 04:24:17PM +0100, Jonathan Neuschäfer wrote:
> > > The Kobo Aura is an e-book reader released in 2013.
> [...]
> > > +	sd2_pwrseq: pwrseq {
> > > +		compatible = "mmc-pwrseq-simple";
> > > +		pinctrl-names = "default";
> > > +		pinctrl-0 = <&pinctrl_sd2_reset>;
> > > +
> > 
> > Please do not have random newlines.
> 
> Does that apply to all empty lines between properties?

Yes, that's what we do for i.MX device trees.

> 
> > 
> > > +		reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> > > +	};
> > > +
> [...]
> > > +&iomuxc {
> > > +	pinctrl_uart2: uart2 {
> > > +		fsl,pins = <
> > > +			MX50_PAD_UART2_TXD__UART2_TXD_MUX	0x1e4
> > > +			MX50_PAD_UART2_RXD__UART2_RXD_MUX	0x1e4
> > > +		>;
> > > +	};
> > > +
> > > +	pinctrl_i2c1: i2c1 {
> > 
> > Please sort these pinctrl nodes alphabetically.
> 
> It doesn't make a difference here, but should I generally sort by name
> or by label in cases like this one?

Keep using the naming schema below, and it always makes no difference
then.

	pinctrl_xxx: xxx

Shawn