linux-kernel - Re: [PATCH] scsi: bnx2fc: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bde8b876-eda6-b23b-5401-cd07015fd767@codeaurora.org>
Date:   Fri, 29 Mar 2019 12:40:08 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Ding Xiang <dingxiang@...s.chinamobile.com>,
        QLogic-Storage-Upstream@...gic.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: bnx2fc: remove unneeded variable


On 3/29/2019 8:54 AM, Ding Xiang wrote:
> "rc" is unneeded,just return SUCCESS

"rc variable is  not needed in `bnx2fc_abts_cleanup`. Fix this by 
removing it ."


Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

-Mukesh

>
> Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>
> ---
>   drivers/scsi/bnx2fc/bnx2fc_io.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
> index bc9f2a2..8def63c 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
> @@ -1083,7 +1083,6 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd)
>   static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req)
>   {
>   	struct bnx2fc_rport *tgt = io_req->tgt;
> -	int rc = SUCCESS;
>   	unsigned int time_left;
>   
>   	io_req->wait_for_comp = 1;
> @@ -1110,7 +1109,7 @@ static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req)
>   	kref_put(&io_req->refcount, bnx2fc_cmd_release);
>   
>   	spin_lock_bh(&tgt->tgt_lock);
> -	return rc;
> +	return SUCCESS;
>   }
>   
>   /**