linux-kernel - Re: [PATCH] lib/scatterlist: Remove leftover from sg_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e313491-8859-d47f-f104-6d2d783cd63a@codeaurora.org>
Date:   Fri, 29 Mar 2019 14:06:04 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Gal Pressman <galpress@...zon.com>, linux-kernel@...r.kernel.org
Cc:     Jason Gunthorpe <jgg@...lanox.com>
Subject: Re: [PATCH] lib/scatterlist: Remove leftover from sg_page_iter
 comment


On 3/29/2019 12:44 AM, Gal Pressman wrote:
> Commit d901b2760dc6 ("lib/scatterlist: Provide a DMA page iterator")
> added the sg DMA iterator but a leftover remained in the sg_page_iter
> documentation, remove it.
>
> Cc: Jason Gunthorpe <jgg@...lanox.com>
> Signed-off-by: Gal Pressman <galpress@...zon.com>
> ---
>   include/linux/scatterlist.h | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
> index b4be960c7e5d..30a9a55c28ba 100644
> --- a/include/linux/scatterlist.h
> +++ b/include/linux/scatterlist.h
> @@ -340,11 +340,11 @@ int sg_alloc_table_chained(struct sg_table *table, int nents,
>    * sg page iterator
>    *
>    * Iterates over sg entries page-by-page.  On each successful iteration, you
> - * can call sg_page_iter_page(@piter) to get the current page and its dma
> - * address.


It took me a while till i exact found what you meant by left over.

could have been more specific in the commit,but

Looks  good to me to be removed.

Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

-Mukesh


>   @piter->sg will point to the sg holding this page and
> - * @piter->sg_pgoffset to the page's page offset within the sg. The iteration
> - * will stop either when a maximum number of sg entries was reached or a
> - * terminating sg (sg_last(sg) == true) was reached.
> + * can call sg_page_iter_page(@piter) to get the current page.
> + * @piter->sg will point to the sg holding this page and @piter->sg_pgoffset to
> + * the page's page offset within the sg. The iteration will stop either when a
> + * maximum number of sg entries was reached or a terminating sg
> + * (sg_last(sg) == true) was reached.
>    */
>   struct sg_page_iter {
>   	struct scatterlist	*sg;		/* sg holding the page */