[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1553818562-2516-1-git-send-email-john.stultz@linaro.org>
Date: Thu, 28 Mar 2019 17:15:56 -0700
From: John Stultz <john.stultz@...aro.org>
To: lkml <linux-kernel@...r.kernel.org>
Cc: John Stultz <john.stultz@...aro.org>,
Laura Abbott <labbott@...hat.com>,
Benjamin Gaignard <benjamin.gaignard@...aro.org>,
Sumit Semwal <sumit.semwal@...aro.org>,
Liam Mark <lmark@...eaurora.org>,
Pratik Patel <pratikp@...eaurora.org>,
Brian Starkey <Brian.Starkey@....com>,
Vincent Donnefort <Vincent.Donnefort@....com>,
Sudipto Paul <Sudipto.Paul@....com>,
"Andrew F . Davis" <afd@...com>,
Xu YiPing <xuyiping@...ilicon.com>,
"Chenfeng (puck)" <puck.chen@...ilicon.com>,
butao <butao@...ilicon.com>,
"Xiaqing (A)" <saberlily.xia@...ilicon.com>,
Yudongbin <yudongbin@...ilicon.com>,
Christoph Hellwig <hch@...radead.org>,
Chenbo Feng <fengc@...gle.com>,
Alistair Strachan <astrachan@...gle.com>,
dri-devel@...ts.freedesktop.org
Subject: [RFC][PATCH 0/6 v3] DMA-BUF Heaps (destaging ION)
Here is another RFC of the dma-buf heaps patchset Andrew and I
have been working on which tries to destage a fair chunk of ION
functionality.
The patchset implements per-heap devices which can be opened
directly and then an ioctl is used to allocate a dmabuf from the
heap.
The interface is similar, but much simpler then IONs, only
providing an ALLOC ioctl.
Also, I've provided simple system and cma heaps. The system
heap in particular is missing the page-pool optimizations ION
had, but works well enough to validate the interface.
I've booted and tested these patches with AOSP on the HiKey960
using the kernel tree here:
https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=dev/dma-buf-heap
And the userspace changes here:
https://android-review.googlesource.com/c/device/linaro/hikey/+/909436
Compared to ION, this patchset is missing the system-contig,
carveout and chunk heaps, as I don't have a device that uses
those, so I'm unable to do much useful validation there.
Additionally we have no upstream users of chunk or carveout,
and the system-contig has been deprecated in the common/andoid-*
kernels, so this should be ok.
I've also removed the stats accounting for now, since it should
be implemented by the heaps themselves.
New in v3:
* Proper /dev/heap/* names on both Android and classic Linux
environments
* Major rework of the helper code from Andrew
* Dummy test device added to test importing
* *Lots* of cleanups suggested by many (thank you for all the
input)!
Outstanding concerns:
* Potential need for private flags in interface for secure
heaps. Need to better understand secure heap usage.
* Making sure the performance issues from potentially unnecessary
cache-management operations can be resolved properly for system
and cma heaps (outstanding issue from ION).
Eventual TODOS:
* Sanity filtering for heap names
* Reimplement performance optimizations for system heap
* Add stats accounting to system/cma heaps
* Make the kselftest more useful
* Add other heaps folks see as useful (would love to get
some help from actual carveout/chunk users)!
That said, the main user-interface is shaping up and I wanted
to get some input on the device model (particularly from GreKH)
and any other API/ABI specific input.
thanks
-john
Cc: Laura Abbott <labbott@...hat.com>
Cc: Benjamin Gaignard <benjamin.gaignard@...aro.org>
Cc: Sumit Semwal <sumit.semwal@...aro.org>
Cc: Liam Mark <lmark@...eaurora.org>
Cc: Pratik Patel <pratikp@...eaurora.org>
Cc: Brian Starkey <Brian.Starkey@....com>
Cc: Vincent Donnefort <Vincent.Donnefort@....com>
Cc: Sudipto Paul <Sudipto.Paul@....com>
Cc: Andrew F. Davis <afd@...com>
Cc: Xu YiPing <xuyiping@...ilicon.com>
Cc: "Chenfeng (puck)" <puck.chen@...ilicon.com>
Cc: butao <butao@...ilicon.com>
Cc: "Xiaqing (A)" <saberlily.xia@...ilicon.com>
Cc: Yudongbin <yudongbin@...ilicon.com>
Cc: Christoph Hellwig <hch@...radead.org>
Cc: Chenbo Feng <fengc@...gle.com>
Cc: Alistair Strachan <astrachan@...gle.com>
Cc: dri-devel@...ts.freedesktop.org
Andrew F. Davis (2):
dma-buf: Add dma-buf heaps framework
dma-buf: Add Dummy Importer Test Device
John Stultz (4):
dma-buf: heaps: Add heap helpers
dma-buf: heaps: Add system heap to dmabuf heaps
dma-buf: heaps: Add CMA heap to dmabuf heapss
kselftests: Add dma-heap test
MAINTAINERS | 18 ++
drivers/dma-buf/Kconfig | 16 ++
drivers/dma-buf/Makefile | 3 +
drivers/dma-buf/dma-buf-testdev.c | 239 +++++++++++++++++++
drivers/dma-buf/dma-heap.c | 234 ++++++++++++++++++
drivers/dma-buf/heaps/Kconfig | 14 ++
drivers/dma-buf/heaps/Makefile | 4 +
drivers/dma-buf/heaps/cma_heap.c | 170 ++++++++++++++
drivers/dma-buf/heaps/heap-helpers.c | 261 +++++++++++++++++++++
drivers/dma-buf/heaps/heap-helpers.h | 55 +++++
drivers/dma-buf/heaps/system_heap.c | 120 ++++++++++
include/linux/dma-heap.h | 58 +++++
include/uapi/linux/dma-buf-testdev.h | 37 +++
include/uapi/linux/dma-heap.h | 52 ++++
tools/testing/selftests/dmabuf-heaps/Makefile | 11 +
tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 169 +++++++++++++
16 files changed, 1461 insertions(+)
create mode 100644 drivers/dma-buf/dma-buf-testdev.c
create mode 100644 drivers/dma-buf/dma-heap.c
create mode 100644 drivers/dma-buf/heaps/Kconfig
create mode 100644 drivers/dma-buf/heaps/Makefile
create mode 100644 drivers/dma-buf/heaps/cma_heap.c
create mode 100644 drivers/dma-buf/heaps/heap-helpers.c
create mode 100644 drivers/dma-buf/heaps/heap-helpers.h
create mode 100644 drivers/dma-buf/heaps/system_heap.c
create mode 100644 include/linux/dma-heap.h
create mode 100644 include/uapi/linux/dma-buf-testdev.h
create mode 100644 include/uapi/linux/dma-heap.h
create mode 100644 tools/testing/selftests/dmabuf-heaps/Makefile
create mode 100644 tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
--
2.7.4
Powered by blists - more mailing lists