linux-kernel - Re: [PATCH] block/bfq: fix ifdef for CONFIG_BFQ_GROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c87a84f-9fb2-2407-a5a3-723b314d8e58@applied-asynchrony.com>
Date:   Fri, 29 Mar 2019 17:44:13 +0100
From:   Holger Hoffstätte <holger@...lied-asynchrony.com>
To:     Jens Axboe <axboe@...nel.dk>,
        Konstantin Khlebnikov <khlebnikov@...dex-team.ru>,
        linux-block@...r.kernel.org,
        Paolo Valente <paolo.valente@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block/bfq: fix ifdef for CONFIG_BFQ_GROUP_IOSCHED=y

On 3/29/19 5:15 PM, Jens Axboe wrote:
>>>> Good catch! I run without group scheduling and therefore didn't notice these
>>>> stray defines earlier. For 5.1 it should merge cleanly; adding this on top of
>>>> the pending 5.2 BFQ patches required a small context fixup in hunk #1 due to
>>>> "block, bfq: do not idle for lowest-weight queues".
>>>
>>> I'm hesitant to apply this, since the group scheduling stuff has obviously never
>>> been tested.
>>
>> This is simply a regression in 5.1 caused by 73d58118498b - nothing else,
>> and as such this fix needs to go into 5.1 as well. I'm sure Paolo will agree.
>> What you so ominously  call "the group scheduling stuff" has been there and
>> shipping in mainline since day 1 of the BFQ merge, and it works fine in 5.0.
> 
> If that's the case (I didn't check how far back it went), then yes, it should
> of course go into 5.1.

Yay.

> The ominous nature of my reply I'll chalk up to your interpretation

Fair enough ;)

A more interesting question is why upstream uses undefined defines
for patches. That's a first-rate self-grenade if I've ever seen one,
and obviously something that is easily missed. Paolo?

-h