linux-kernel - Re: [PATCH] gcov: include linux/module.h for within

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdmv4_8pN5r8EO8c59WN+EE7ZPST8qHKMg7SzPH1rzaqag@mail.gmail.com>
Date:   Fri, 29 Mar 2019 11:09:28 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Hackmann <ghackmann@...roid.com>,
        Tri Vo <trong@...roid.com>,
        Linux Memory Management List <linux-mm@...ck.org>,
        kbuild-all@...org, kbuild test robot <lkp@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gcov: include linux/module.h for within_module

On Fri, Mar 29, 2019 at 11:01 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 3/29/19 10:45 AM, Nick Desaulniers wrote:
> > Fixes commit 8c3d220cb6b5 ("gcov: clang support")
> >
> > Cc: Greg Hackmann <ghackmann@...roid.com>
> > Cc: Tri Vo <trong@...roid.com>
> > Cc: Peter Oberparleiter <oberpar@...ux.ibm.com>
> > Cc: linux-mm@...ck.org
> > Cc: kbuild-all@...org
> > Reported-by: kbuild test robot <lkp@...el.com>
> > Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
> > Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> see https://lore.kernel.org/linux-mm/20190328225107.ULwYw%25akpm@linux-foundation.org/T/#mee26c00158574326e807480fc39dfcbd7bebd5fd
>
> Did you test this?

Yes, built with gcc 7.3 and
defconfig
+
CONFIG_GCOV_KERNEL=y
CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y
CONFIG_GCOV_FORMAT_4_7=y

> kernel/gcov/gcc_4_7.c includes local "gcov.h",
> which includes <linux/module.h>, so why didn't that work or why
> does this patch work?

Good point. May be something in the configs from 0-day bot.  Boarding
a plane for Bangkok, but can dig further once landed.

Maybe module support was disabled?

--
Thanks,
~Nick Desaulniers