lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Mar 2019 15:13:21 +1300 From: Chris Packham <chris.packham@...iedtelesis.co.nz> To: bbrezillon@...nel.org, computersforpeace@...il.com, dwmw2@...radead.org, marek.vasut@...il.com, richard@....at, robh+dt@...nel.org, mark.rutland@....com Cc: linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Chris Packham <chris.packham@...iedtelesis.co.nz>, stable@...r.kernel.org, Boris Brezillon <boris.brezillon@...labora.com> Subject: [PATCH v2 1/2] mtd: maps: physmap: Store gpio_values correctly When the gpio-addr-flash.c driver was merged with physmap-core.c the code to store the current gpio_values was lost. This meant that once a gpio was asserted it was never de-asserted. Fix this by storing the current offset in gpio_values like the old driver used to. Fixes: commit ba32ce95cbd9 ("mtd: maps: Merge gpio-addr-flash.c into physmap-core.c") Cc: <stable@...r.kernel.org> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz> Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com> --- Changes in v2: - Cc stable, add Boris' review drivers/mtd/maps/physmap-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/maps/physmap-core.c b/drivers/mtd/maps/physmap-core.c index d9a3e4bebe5d..21b556afc305 100644 --- a/drivers/mtd/maps/physmap-core.c +++ b/drivers/mtd/maps/physmap-core.c @@ -132,6 +132,8 @@ static void physmap_set_addr_gpios(struct physmap_flash_info *info, gpiod_set_value(info->gpios->desc[i], !!(BIT(i) & ofs)); } + + info->gpio_values = ofs; } #define win_mask(order) (BIT(order) - 1) -- 2.21.0
Powered by blists - more mailing lists