linux-kernel - Re: [PATCH v4 2/7] drm/panel: simple: Add ability to override typical timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1637882.fJ8YATuT5C@diego>
Date:   Fri, 29 Mar 2019 20:13:33 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Sean Paul <seanpaul@...omium.org>,
        linux-rockchip@...ts.infradead.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        dri-devel@...ts.freedesktop.org,
        Boris Brezillon <boris.brezillon@...labora.com>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        Enric Balletbò <enric.balletbo@...labora.com>,
        Rob Herring <robh+dt@...nel.org>, mka@...omium.org,
        Eric Anholt <eric@...olt.net>,
        Jeffy Chen <jeffy.chen@...k-chips.com>,
        Stéphane Marchesin <marcheu@...omium.org>,
        devicetree@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        linux-kernel@...r.kernel.org, Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH v4 2/7] drm/panel: simple: Add ability to override typical timing

Am Donnerstag, 28. März 2019, 18:17:05 CET schrieb Douglas Anderson:
> From: Sean Paul <seanpaul@...omium.org>
> 
> This patch adds the ability to override the typical display timing for a
> given panel. This is useful for devices which have timing constraints
> that do not apply across the entire display driver (eg: to avoid
> crosstalk between panel and digitizer on certain laptops). The rules are
> as follows:
> 
> - panel must not specify fixed mode (since the override mode will
>   either be the same as the fixed mode, or we'll be unable to
>   check the bounds of the overried)
> - panel must specify at least one display_timing range which will be
>   used to ensure the override mode fits within its bounds
> 
> Changes in v2:
>  - Parse the full display-timings node (using the native-mode) (Rob)
> Changes in v3:
>  - No longer parse display-timings subnode, use panel-timing (Rob)
> Changes in v4:
>  - Don't add mode from timing if override was specified (Thierry)
>  - Add warning if timing and fixed mode was specified (Thierry)
>  - Don't add fixed mode if timing was specified (Thierry)
>  - Refactor/rename a bit to avoid extra indentation from "if" tests
>  - i should be unsigned (Thierry)
>  - Add annoying WARN_ONs for some cases (Thierry)
>  - Simplify 'No display_timing found' handling (Thierry)
>  - Rename to panel_simple_parse_override_mode() (Thierry)
> 
> Cc: Doug Anderson <dianders@...omium.org>
> Cc: Eric Anholt <eric@...olt.net>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: Jeffy Chen <jeffy.chen@...k-chips.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Stéphane Marchesin <marcheu@...omium.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: devicetree@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Sean Paul <seanpaul@...omium.org>
> Tested-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

on a rk3399-kevin and rk3288-jerry
Tested-by: Heiko Stuebner <heiko@...ech.de>