linux-kernel - Re: [PATCH] staging: rtl8723bs: core: fix line over 80 characters warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ffd4bc1-bdc2-7e11-3309-ff6e7d3c206b@codeaurora.org>
Date:   Sat, 30 Mar 2019 02:46:41 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Anirudh Rayabharam <anirudh.rayabharam@...il.com>,
        gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        hadess@...ess.net, hdegoede@...hat.com
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: fix line over 80 characters
 warning


On 3/26/2019 11:55 PM, Anirudh Rayabharam wrote:
> Shorten the expression by re-using the part that was already computed to
> fix the line over 80 characters warning reported by checkpatch.pl.
>
> Signed-off-by: Anirudh Rayabharam <anirudh.rayabharam@...il.com>
> ---
>   drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 18fabf5ff44b..bc0230672457 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -2336,8 +2336,8 @@ void rtw_ap_restore_network(struct adapter *padapter)
>   			Update_RA_Entry(padapter, psta);
>   			/* pairwise key */
>   			/* per sta pairwise key and settings */
> -			if ((padapter->securitypriv.dot11PrivacyAlgrthm == _TKIP_) ||
> -				(padapter->securitypriv.dot11PrivacyAlgrthm == _AES_)) {
> +			if ((psecuritypriv->dot11PrivacyAlgrthm == _TKIP_) ||
> +				(psecuritypriv->dot11PrivacyAlgrthm == _AES_)) {
>   				rtw_setstakey_cmd(padapter, psta, true, false);
>   			}


Get rid of this {}.fix this .

Now patch looks good after Dan comment.
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

>   		}