linux-kernel - Re: [PATCH] rcu: tree_plugin: Dump specified number of blocked tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190329212702.GA4102@linux.ibm.com>
Date:   Fri, 29 Mar 2019 14:27:02 -0700
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     Mukesh Ojha <mojha@...eaurora.org>
Cc:     Neeraj Upadhyay <neeraju@...eaurora.org>, josh@...htriplett.org,
        rostedt@...dmis.org, mathieu.desnoyers@...icios.com,
        jiangshanlai@...il.com, joel@...lfernandes.org,
        rcu@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu: tree_plugin: Dump specified number of blocked tasks

On Fri, Mar 29, 2019 at 03:42:44PM +0530, Mukesh Ojha wrote:
> 
> On 3/29/2019 3:25 PM, Neeraj Upadhyay wrote:
> >dump_blkd_tasks() uses 10 as the max number of blocked
> >tasks, which are printed. However, it has an argument
> >which provides that number. So, use the argument value
> >instead. As all callers currently pass 10 as the number,
> >there isn't any impact.
> >
> >Signed-off-by: Neeraj Upadhyay <neeraju@...eaurora.org>
> 
> Looks good to me.
> 
> Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Applied, thank you both!

							Thanx, Paul

> Cheers,
> -Mukesh
> 
> >---
> >  kernel/rcu/tree_plugin.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> >index 3960294..08bcd87 100644
> >--- a/kernel/rcu/tree_plugin.h
> >+++ b/kernel/rcu/tree_plugin.h
> >@@ -740,7 +740,7 @@ void exit_rcu(void)
> >  	i = 0;
> >  	list_for_each(lhp, &rnp->blkd_tasks) {
> >  		pr_cont(" %p", lhp);
> >-		if (++i >= 10)
> >+		if (++i >= ncheck)
> >  			break;
> >  	}
> >  	pr_cont("\n");
>