linux-kernel - Re: [RFC][PATCH 0/4 v2] sycalls: Remove args i and n from syscall_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-8e9b547b-7fe3-43d2-9dea-b217de923605@palmer-si-x1c4>
Date:   Fri, 29 Mar 2019 21:05:27 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...ive.com>
To:     rostedt@...dmis.org
CC:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, mingo@...nel.org,
        akpm@...ux-foundation.org, luto@...capital.net,
        roland@...k.frob.com, oleg@...hat.com, linux-arch@...r.kernel.org,
        peterz@...radead.org, tglx@...utronix.de, gustavo@...eddedor.com,
        bp@...en8.de, hpa@...or.com, x86@...nel.org,
        linux@...inikbrodowski.net, luto@...nel.org, keescook@...omium.org,
        ebiederm@...ssion.com, ldv@...linux.org
Subject:     Re: [RFC][PATCH 0/4 v2] sycalls: Remove args i and n from syscall_get_arguments()

On Fri, 29 Mar 2019 10:40:45 PDT (-0700), rostedt@...dmis.org wrote:
> On Fri, 29 Mar 2019 10:24:58 -0700
> Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>
>> The whole series looks fine to me.
>
> Great! I may just send a pull request to you, after some fixes (see
> below).
>
>>
>> I still suspect that we should just remove the syscall_set_arguments()
>> thing entirely, but even without that, the cleanup of the calling
>> convention is at least an improvement.
>
> I'll keep it around for now, but this should go as a warning to Dmitry,
> to get something using it soon, or they may be dropped.
>
> Also, Dmitry found a few bugs with the current
> syscall_set/get_arguments() on some of the archs (riscv and csky). Which
> I'll add at the front of this series and update my changes to keep the
> same logic.

Thanks.  I'm happy to have you take the RISC-V fix through your tree.

>
> Then I'll post a non RFC version.
>
> -- Steve