linux-kernel - Re: [PATCH 1/4] mt76: add mac80211 driver for MT7615 PCIe-based chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lg0wyjvj.fsf@purkki.adurom.net>
Date:   Sat, 30 Mar 2019 08:08:32 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Ryder Lee <ryder.lee@...iatek.com>
Cc:     Lorenzo Bianconi <lorenzo.bianconi@...hat.com>,
        Felix Fietkau <nbd@....name>, Roy Luo <royluo@...gle.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Nelson Chang <nelson.chang@...iatek.com>,
        YF Luo <yf.luo@...iatek.com>, Kai Lin <kai.lin@...iatek.com>,
        Rorscha Yang <rorscha.yang@...iatek.com>,
        Kyle Lee <kyle.lee@...iatek.com>,
        Miller Shen <miller.shen@...iatek.com>,
        Haipin Liang <haipin.liang@...iatek.com>,
        <linux-wireless@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Lorenzo Bianconi <lorenzo@...nel.org>
Subject: Re: [PATCH 1/4] mt76: add mac80211 driver for MT7615 PCIe-based chipsets

Ryder Lee <ryder.lee@...iatek.com> writes:

> This driver is for a newer generation of MediaTek MT7615 4x4 802.11ac
> PCIe-based chipsets, which support wave2 MU-MIMO up to 4 users/group
> and also support up to 160MHz bandwidth.
>
> The driver fully supports AP, station and monitor mode.
>
> Signed-off-by: Ryder Lee <ryder.lee@...iatek.com>
> Signed-off-by: Roy Luo <royluo@...gle.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>

[...]

> --- /dev/null
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/dma.c
> @@ -0,0 +1,204 @@
> +// SPDX-License-Identifier: GPL-2.0

mt76 is under ISC so why did you choose GPLv2 here? I don't think it's a
good idea to use different licenses within the same driver.

Also mt76 does not use SPDX tags yet. I would prefer that the whole
driver is converted in one go to have consistent licensing information.

-- 
Kalle Valo