linux-kernel - Re: [PATCH v2 1/2] clk:Fix divide-by-zero in divider_ro_round_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcbcceb2-e59b-465a-ec36-cde354425898@codeaurora.org>
Date:   Sat, 30 Mar 2019 15:14:10 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     nixiaoming <nixiaoming@...wei.com>, jbrunet@...libre.com,
        mturquette@...libre.com, sboyd@...eaurora.org,
        soren.brinkmann@...inx.com
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] clk:Fix divide-by-zero in
 divider_ro_round_rate_parent


On 3/30/2019 8:01 AM, nixiaoming wrote:
> In the function divider_recalc_rate() The judgment of the return value of
> _get_div() indicates that the return value of _get_div() may be 0.

s/may be/can be


> In order to avoid the divide-by-zero error, add check the return values.
s/add check the/add check for

> of _get_div() in the divider_ro_round_rate_parent()
>
> Signed-off-by: nixiaoming <nixiaoming@...wei.com>


Please fix the commit text.
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/clk/clk-divider.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
> index e5a1726..f4bf7a4 100644
> --- a/drivers/clk/clk-divider.c
> +++ b/drivers/clk/clk-divider.c
> @@ -347,6 +347,9 @@ long divider_ro_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent,
>   	int div;
>   
>   	div = _get_div(table, val, flags, width);
> +	/* avoid divide-by-zero */
> +	if (!div)
> +		return -EINVAL;
>   
>   	/* Even a read-only clock can propagate a rate change */
>   	if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) {