linux-kernel - Re: [PATCH -next] crypto: marvell - remove set but not used variable 'index'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd033699-1660-a92e-08ec-0bdfa3113428@codeaurora.org>
Date:   Sat, 30 Mar 2019 15:45:05 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Yue Haibing <yuehaibing@...wei.com>, bbrezillon@...nel.org,
        arno@...isbad.org, herbert@...dor.apana.org.au, davem@...emloft.net
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH -next] crypto: marvell - remove set but not used variable
 'index'


On 3/30/2019 10:58 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/crypto/marvell/hash.c: In function 'mv_cesa_ahash_pad_req':
> drivers/crypto/marvell/hash.c:138:15: warning: variable 'index' set but not used [-Wunused-but-set-variable]
>
> It's never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/crypto/marvell/hash.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/marvell/hash.c b/drivers/crypto/marvell/hash.c
> index 99ff54c..fd456dd 100644
> --- a/drivers/crypto/marvell/hash.c
> +++ b/drivers/crypto/marvell/hash.c
> @@ -135,11 +135,10 @@ static int mv_cesa_ahash_pad_len(struct mv_cesa_ahash_req *creq)
>   
>   static int mv_cesa_ahash_pad_req(struct mv_cesa_ahash_req *creq, u8 *buf)
>   {
> -	unsigned int index, padlen;
> +	unsigned int padlen;
>   
>   	buf[0] = 0x80;
>   	/* Pad out to 56 mod 64 */
> -	index = creq->len & CESA_HASH_BLOCK_SIZE_MSK;
>   	padlen = mv_cesa_ahash_pad_len(creq);
>   	memset(buf + 1, 0, padlen - 1);
>