lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 31 Mar 2019 18:54:46 +0200 (CEST) From: Thomas Gleixner <tglx@...utronix.de> To: Sebastian Andrzej Siewior <bigeasy@...utronix.de> cc: linux-kernel@...r.kernel.org, x86@...nel.org, Andy Lutomirski <luto@...nel.org>, Paolo Bonzini <pbonzini@...hat.com>, Radim Krčmář <rkrcmar@...hat.com>, kvm@...r.kernel.org, "Jason A. Donenfeld" <Jason@...c4.com>, Rik van Riel <riel@...riel.com>, Dave Hansen <dave.hansen@...ux.intel.com> Subject: Re: [PATCH 17/24] x86/fpu: Always store the registers in copy_fpstate_to_sigframe() On Thu, 21 Mar 2019, Sebastian Andrzej Siewior wrote: > @@ -169,9 +155,15 @@ int copy_fpstate_to_sigframe(void __user *buf, void __user *buf_fx, int size) > sizeof(struct user_i387_ia32_struct), NULL, > (struct _fpstate_32 __user *) buf) ? -1 : 1; > > - /* Save the live register state to the user directly. */ > - if (copy_fpregs_to_sigframe(buf_fx)) > - return -1; > + copy_fpregs_to_fpstate(fpu); > + > + if (using_compacted_format()) { > + copy_xstate_to_user(buf_fx, xsave, 0, size); This needs to check the return value. > + } else { > + fpstate_sanitize_xstate(fpu); > + if (__copy_to_user(buf_fx, xsave, fpu_user_xstate_size)) > + return -1; > + } Thanks, tglx
Powered by blists - more mailing lists