linux-kernel - Re: [PATCH v2 6/7] fbdev: sm712fb: Kconfig: add information about docs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 31 Mar 2019 20:01:18 +0100
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Yifeng Li <tomli@...li.me>
Cc:     Teddy Wang <teddy.wang@...iconmotion.com>,
        linux-kernel@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 6/7] fbdev: sm712fb: Kconfig: add information about
 docs.

On Fri, Mar 22, 2019 at 01:17:58PM +0800, Yifeng Li wrote:
> This commits update the Kconfig description of sm712fb,
> and inform the user about the existence of documentation.
> 
> Signed-off-by: Yifeng Li <tomli@...li.me>
> ---
>  Documentation/fb/sm712fb.txt | 44 ++++++++++++++++++++----------------
>  drivers/video/fbdev/Kconfig  |  4 ++++
>  2 files changed, 29 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/fb/sm712fb.txt b/Documentation/fb/sm712fb.txt
> index 906b48aa40e4..c9a8fe059ac7 100644
> --- a/Documentation/fb/sm712fb.txt
> +++ b/Documentation/fb/sm712fb.txt
> @@ -18,9 +18,10 @@ and it was also an inexpensive platform for non-x86 hobbyists to explore.
>  How to use it?
>  ==============
>  
> -You should not compile-in vesafb, since SM7xx can be used in a VGA
> -compatible mode, resulting conflicts with this driver. In addition,
> -the VGA compatible mode was never tested by the maintainers.
> +SM7xx can be used in a VGA compatible mode and a native framebuffer mode,
> +this driver is a native driver. By default, it has no problem taking over
> +the VGA driver automatically, but you should not attempt to use both at
> +the same time.

You added this in the documentation with just the previous patch.

>  

<snip>

>  
>  2D acceleration
>  ==============
> @@ -97,7 +103,7 @@ Missing Features
>  
>  The following features are not implemented in this driver,
>  
> -	* 2D acceleration on SM720 and Big-Endian CPUs.
> +	* 2D acceleration on Big-Endian CPUs.
>  	* More VGA modes.
>  	* dual-head support
>  	* hardware cursor support

You might want to squash the two patches for documentation instead of
having a separate patch to fix what you added in a previous patch.

--
Regards
Sudip