linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: counter: Add Milbeaut Updown Counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 31 Mar 2019 01:42:04 -0500
From:   Rob Herring <robh@...nel.org>
To:     Shinji Kanematsu <kanematsu.shinji@...ionext.com>
Cc:     jic23@...nel.org, mark.rutland@....com, knaack.h@....de,
        lars@...afoo.de, pmeerw@...erw.net, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        masami.hiramatsu@...aro.org, jaswinder.singh@...aro.org,
        orito.takao@...ionext.com, sugaya.taichi@...ionext.com,
        kasai.kazuhiro@...ionext.com
Subject: Re: [PATCH 1/2] dt-bindings: iio: counter: Add Milbeaut Updown
 Counter

On Tue, Mar 26, 2019 at 03:33:09PM +0900, Shinji Kanematsu wrote:
> Add documentation for Milbeaut Updown Counter device
> quadrature encoder and counter binding.
> 
> Signed-off-by: Shinji Kanematsu <kanematsu.shinji@...ionext.com>
> ---
>  .../bindings/iio/counter/milbeaut-updown_cnt.txt   | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/counter/milbeaut-updown_cnt.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/counter/milbeaut-updown_cnt.txt b/Documentation/devicetree/bindings/iio/counter/milbeaut-updown_cnt.txt
> new file mode 100644
> index 0000000..6771567
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/counter/milbeaut-updown_cnt.txt
> @@ -0,0 +1,22 @@
> +SOCIONEXT Milbeaut Updown counter
> +
> +Required properties:
> +- compatible:       Must be "socionext,milbeaut-updown-counter".
> +- reg:              Offset and length of the device's register set.
> +- clocks:           Phandle to the clock used by the Updown counter module.
> +- clock-names:      Must be "mux".
> +- interrupts:       SPI number of the device's set.
> +- cms_type:         connected_device
> +                     1: updown button  (updown counter mode)
> +                     2: rotary encoder (phase difference counter mode)

We should have a common property for describing what's attached. 
IIRC, just had a similar binding recently.

> +
> +Example:
> +
> +	updown0: updown@...02000 {
> +		compatible = "socionext,milbeaut-updown-counter";
> +		reg = <0x1e002000 0x20>;
> +		clocks = <&clk 4>;
> +		clock-names = "mux";
> +		interrupts = <0 104 0x4>;
> +		cms_type = <1>;
> +	};
> -- 
> 1.9.1
>