lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 31 Mar 2019 10:00:18 +0300
From:   Andrey Abramov <st5pub@...dex.ru>
To:     George Spelvin <lkml@....org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "bp@...en8.de" <bp@...en8.de>,
        "darrick.wong@...cle.com" <darrick.wong@...cle.com>,
        "dchinner@...hat.com" <dchinner@...hat.com>,
        "dedekind1@...il.com" <dedekind1@...il.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "jlbec@...lplan.org" <jlbec@...lplan.org>,
        "jpoimboe@...hat.com" <jpoimboe@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "mark@...heh.com" <mark@...heh.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "naveen.n.rao@...ux.vnet.ibm.com" <naveen.n.rao@...ux.vnet.ibm.com>,
        "paulus@...ba.org" <paulus@...ba.org>,
        "richard@....at" <richard@....at>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "vgupta@...opsys.com" <vgupta@...opsys.com>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH 5/5] Lib: sort.h: replace int size with size_t size in the swap function

30.03.2019, 23:17, "George Spelvin" <lkml@....org>:
> On Sat, 30 Mar 2019 at 19:38:26 +0100 greh k-h wrote;
>>  On Sat, Mar 30, 2019 at 07:43:53PM +0300, Andrey Abramov wrote:
>>>  Replace int type with size_t type of the size argument
>>>  in the swap function, also affect all its dependencies.
>>
>>  This says _what_ the patch does, but it gives no clue as to _why_ you
>>  are doing this. Neither did your 0/5 patch :(
>>
>>  Why make this change? Nothing afterward depends on it from what I can
>>  tell, so why is it needed?
>
> It's just a minor cleanup, making things less surprising for future
> programmers. As I wrote in a comment in my patches, using a signed type
> for an object size is definitely a wart; ever since C89 it's expected
> you'd use size_t for the purpose.
>
> The connection is that it's a natural consequence of doing a pass over
> every call site.
>
> You're right it could be dropped from the series harmlessly, but it
> comes from the same work. But it's all of *three* call sites in the kernel
> which are affected. Surely that's not an unreasonable amount of churn
> to clean up a wart?

George Spelvin is absolutely right: "It's just a minor cleanup, making things less surprising for future programmers."

31.03.2019, 00:51, "George Spelvin" <lkml@....org>:
> It was so obvious to me that I didn't question it, but you have a
> good point and I'm sure Andrey can clarify. Thanks for the attention!

I thought that it is obvious enough (argument called "size" should be of type size_t in the 90% of cases).
Should I resend this patch with better explanation "why"?

-- 
With Best Regards,
Andrey Abramov

Powered by blists - more mailing lists