linux-kernel - Re: net: fix routing encapsulated packets when binding a socket to a tunnel interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190331.230123.1312457672309077256.davem@davemloft.net>
Date:   Sun, 31 Mar 2019 23:01:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lifonghsu@...ology.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: net: fix routing encapsulated packets when binding a socket to
 a tunnel interface

From: lifonghsu <lifonghsu@...ology.com>
Date: Mon, 01 Apr 2019 11:00:22 +0800

> Since we are not sure whether there is any code referring to the
> value of skb_iff in transmit site or not, it is risky to set an
> invalid interface

If you are no confident in how the value is used on TX, then I can't
consider your change with confidence either.

Think about what you are saying to me here.  You basically do not know
whether you are adding a bug or not.