linux-kernel - Re: [PATCH] usb: musb: Force-disable pullup on shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1554140782.10471.0@crapouillou.net>
Date:   Mon, 01 Apr 2019 19:46:22 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Bin Liu <b-liu@...com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, od@...c.me
Subject: Re: [PATCH] usb: musb: Force-disable pullup on shutdown



Le lun. 1 avril 2019 à 19:17, Bin Liu <b-liu@...com> a écrit :
> On Thu, Mar 21, 2019 at 03:42:46PM +0100, Paul Cercueil wrote:
>>  When the musb is shutdown, for instance when the driver is unloaded,
>>  force-disable the pullup. Otherwise, the host will still see the 
>> gadget
>>  device even after the shutdown.
> 
> how would this happen?
> 
> when musb-hdrc driver is unloaded, udc core removes the bound gadget
> driver which calls musb_gadget_pullup() to disable the pullup.

I'm testing with the jz4740-musb driver. I don't unload the module (it's
built-in) but unbind it from sysfs.

> Regards,
> -Bin.