[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8736n11ulc.fsf@anholt.net>
Date: Mon, 01 Apr 2019 10:52:31 -0700
From: Eric Anholt <eric@...olt.net>
To: Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
dri-devel@...ts.freedesktop.org
Cc: linux-kernel@...r.kernel.org,
Maxime Ripard <maxime.ripard@...tlin.com>
Subject: Re: [PATCH 1/7] drm: Add a helper function for printing a debugfs_regset32.
Paul Kocialkowski <paul.kocialkowski@...tlin.com> writes:
> Hi,
>
> Le mercredi 20 février 2019 à 13:03 -0800, Eric Anholt a écrit :
>> The debugfs_regset32 is nice to use for reducing boilerplate in
>> dumping a bunch of regs in debugfs, but we also want to be able to
>> print to dmesg them at runtime for driver debugging. drm_printer lets
>> us format debugfs and the printk the same way.
>
> Looks good to me!
>
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Thanks! Merged all but patch 3 (unreviewed) and patch 5 (needs patch 3
to avoid oopsing). Sending out a rebased version shortly.
Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)
Powered by blists - more mailing lists