linux-kernel - RE: [PATCH V1 24/26] spi: tegra114: de-assert CS before SPI mode is reset to its default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR12MB33984E9D0FA76FCC77FD72BFC2550@BYAPR12MB3398.namprd12.prod.outlook.com>
Date:   Mon, 1 Apr 2019 18:07:45 +0000
From:   Sowjanya Komatineni <skomatineni@...dia.com>
To:     Mark Brown <broonie@...nel.org>
CC:     "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Timo Alho <talho@...dia.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "Krishna Yarlagadda" <kyarlagadda@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH V1 24/26] spi: tegra114: de-assert CS before SPI mode is
 reset to its default


> On Tue, Mar 26, 2019 at 10:56:45PM -0700, Sowjanya Komatineni wrote:
> > With SW CS, during transfer completion CS is de-asserted by writing 
> > the default command1 register value to SPI_COMMAND1 register. With 
> > this both mode and CS state are set at the same time and if current 
> > transfer mode is different to default SPI mode and if mode change 
> > happens prior to CS de-assert, clock polarity can change while CS is 
> > active before transfer finishes.
>
> This is a bug fix so I'd expect it to be much earlier in the series before any of the new features.

Thanks Mark. Will change order as per your feedback in next version of patch series.

I see you have applied some patches in V1 series so should I re-send again those as well along with feedback changes in next version or just only the patches that are not applied.