linux-kernel - Re: [PATCH 0/3] locking/static_key: improve rate limited labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190401112153.2f9e87ba@cakuba.hsd1.ca.comcast.net>
Date:   Mon, 1 Apr 2019 11:21:53 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     peterz@...radead.org, tglx@...utronix.de,
        David Miller <davem@...emloft.net>
Cc:     ard.biesheuvel@...aro.org, yamada.masahiro@...ionext.com,
        mingo@...nel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, oss-drivers@...ronome.com,
        alexei.starovoitov@...il.com
Subject: Re: [PATCH 0/3] locking/static_key: improve rate limited labels

On Fri, 29 Mar 2019 17:08:51 -0700, Jakub Kicinski wrote:
> Hi!
> 
> This will be used to fix the static branch disabling in the TLS
> code.  The net/tls/ code should be using the deferred static
> branch type, because unprivileged users can flip the branch
> on and off quite easily with CONFIG_TLS_DEVICE=y.
> 
> Second of all we shouldn't take the jump label locks from
> the RX path, when the socket is destroyed.  This can be avoided
> with some slight code refactoring in deferred static_key as
> it already runs from a workqueue.
> 
> This the series (and a simple tls patch which makes use of it)
> applied opening 0.5M TLS connections to localhost (just calling
> setsockopt, no data exchange) goes down from 37.9s to 12.4s.

Once/if we get positive feedback from locking folks, would it be
possible to merge these via net-next tree alongside the patch
converting TLS to rate limited branches?