linux-kernel - Re: [PATCH v3] tpm: Actually fail on TPM errors during "get random"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKGwH2m1-z9mXeUJh-4GOFw4igPgEv7Z_K5oP4cr0wbYA@mail.gmail.com>
Date:   Mon, 1 Apr 2019 12:14:14 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        James Bottomley <James.Bottomley@...senpartnership.com>,
        Phil Baker <baker1tex@...il.com>,
        Craig Robson <craig@...tt.com>,
        Laura Abbott <labbott@...hat.com>,
        Tomas Winkler <tomas.winkler@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Huewe <peterhuewe@....de>, Arnd Bergmann <arnd@...db.de>,
        linux-integrity <linux-integrity@...r.kernel.org>
Subject: Re: [PATCH v3] tpm: Actually fail on TPM errors during "get random"

On Mon, Apr 1, 2019 at 12:09 PM Jason Gunthorpe <jgg@...pe.ca> wrote:
> > + *   -errno otherwise ((positive TPM return codes are masked to -EIO)
>
> Extra bracket, but otherwise looks fine to me

Thanks! (And I guess it's time for lunch so I can take a break and
learn how to type again...)

-- 
Kees Cook