linux-kernel - Re: [RFC PATCH 3/5] documention: leds: Add multicolor class documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190401212709.GA14681@amd>
Date:   Mon, 1 Apr 2019 23:27:10 +0200
From:   Pavel Machek <pavel@....cz>
To:     Dan Murphy <dmurphy@...com>
Cc:     robh+dt@...nel.org, jacek.anaszewski@...il.com, marek.behun@....cz,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [RFC PATCH 3/5] documention: leds: Add multicolor class
 documentation

Hi!

> +Under the "colors" directory there are two files created "sync" and
> +"sync_enable". The sync_enable file controls whether the LED brightness
> +value is set real time or if the LED brightness value setting is deferred until
> +the "sync" file is written.  If sync_enable is set then writing to each LED
> +"brightness" file will store the brightness value.  Once the "sync" file is
> +written then each LED color defined in the node will write the brightness of
> +the LED in the device driver.
> +
> +If "sync_enable" is not set then writing the brightness value of the LED to the
> +device driver is done immediately.  Writing the "sync" file has no
> affect.

I believe better solutions exists for this problem.

One was discussed before -- have single file which contains
coefficients for r/g/b channels.

Or at least... you should not really need separate sync and
sync_enable files. One should do.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)