linux-kernel - Re: [PATCH v5 1/8] i2c: iproc: Extend I2C read up to 255 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f89a0e5f-14f1-b9a2-44f6-67ff0eaf761c@broadcom.com>
Date:   Mon, 1 Apr 2019 14:35:16 -0700
From:   Ray Jui <ray.jui@...adcom.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>,
        Shreesha Rajashekar <shreesha@...adcom.com>
Subject: Re: [PATCH v5 1/8] i2c: iproc: Extend I2C read up to 255 bytes



On 3/27/2019 3:17 PM, Wolfram Sang wrote:
> 
>> +		if (!((readl(iproc_i2c->base +
>> +		M_FIFO_CTRL_OFFSET) >>
>> +		M_FIFO_RX_CNT_SHIFT) &
>> +		M_FIFO_RX_CNT_MASK))
> 
> Don't be too strict with the 80 char limit. I think the above is hardly
> readable...
> 

Right, that makes sense. Will change to make it more readable than
trying to be compliant to the < 80 chars rule.

>> +			break;
>> +
>> +		msg->buf[iproc_i2c->rx_bytes] =
>> +			(readl(iproc_i2c->base + M_RX_OFFSET) >>
>> +			M_RX_DATA_SHIFT) & M_RX_DATA_MASK;
> 
> ... this here is MUCH better.
> 
> Rest looks good.
> 

Thanks,

Ray