linux-kernel - Re: [PATCH] Documentation: soundwire: Ensure that code is inside the code blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190401225211.GE2095@latitude>
Date:   Tue, 2 Apr 2019 00:52:11 +0200
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Jonathan Corbet <corbet@....net>
Cc:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-doc@...r.kernel.org, Vinod Koul <vkoul@...nel.org>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation: soundwire: Ensure that code is inside the
 code blocks

On Mon, Apr 01, 2019 at 03:40:03PM -0600, Jonathan Corbet wrote:
> On Mon,  1 Apr 2019 00:34:22 +0200
> Jonathan Neuschäfer <j.neuschaefer@....net> wrote:
> 
> > The way the document is written now, Sphinx renders empty code blocks
> > followed by the lines that should be inside them.
> > 
> > Unindent the code-block directives to fix this.
> > 
> > Fixes: 502c00d9c315 ("Documentation: soundwire: fix stream.rst markup warnings")
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> 
> That definitely makes things better.  Applied, thanks.
> 
> I'm going to take out the Fixes tag, though, since the named commit did
> not, in fact, introduce that problem.

Ah, true, the wrong indentation didn't come from that commit.

> It's also good to copy authors of patches named in Fixes tags so they
> can defend themselves :)

Good idea, I'll try to remember that.


Jonathan Neuschäfer

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)