linux-kernel - Re: [PATCH 3/7] irqchip/al-msi: Rename AL-MSIx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 01 Apr 2019 02:49:17 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Hanna Hawa <hhhawa@...zon.com>
Cc:     <tsahee@...apurnalabs.com>, <antoine.tenart@...tlin.com>,
        <linux@...linux.org.uk>, <catalin.marinas@....com>,
        <will.deacon@....com>, <rjw@...ysocki.net>, <lenb@...nel.org>,
        <tglx@...utronix.de>, <jason@...edaemon.net>, <ronenk@...zon.com>,
        <dwmw@...zon.co.uk>, <vaerov@...zon.com>, <zeev@...zon.com>,
        <alisaidi@...zon.com>, <talel@...zon.com>, <jonnyc@...zon.com>,
        <hanochu@...zon.com>, <barakw@...zon.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH 3/7] irqchip/al-msi: Rename AL-MSIx driver

On Sun, 31 Mar 2019 13:34:11 +0100,
Hanna Hawa <hhhawa@...zon.com> wrote:
> 
> Alpine is the name of the SoC family, while AL stands for Annapurna
> Labs. Rename to the latter since the driver will appear in other SoC
> families other than Alpine.
> 
> Add device tree match for "amazon/al-msix".
> 
> Signed-off-by: Hanna Hawa <hhhawa@...zon.com>
> ---
>  arch/arm/mach-alpine/Kconfig                       |  2 +-
>  arch/arm64/Kconfig.platforms                       |  2 +-
>  drivers/irqchip/Kconfig                            |  2 +-
>  drivers/irqchip/Makefile                           |  2 +-
>  drivers/irqchip/{irq-alpine-msi.c => irq-al-msi.c} | 93 +++++++++++-----------
>  5 files changed, 49 insertions(+), 52 deletions(-)
>  rename drivers/irqchip/{irq-alpine-msi.c => irq-al-msi.c} (68%)

Why do we need this churn? It feels absolutely pointless. Adding your
new compatibility string is absolutely fine; repainting the whole
driver because you've found a "better" name for it isn't.

Thanks,

	M.

-- 
Jazz is not dead, it just smell funny.