linux-kernel - Re: [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f50128c-2c8b-c7b5-8c93-eb86fa627e48@codeaurora.org>
Date:   Mon, 1 Apr 2019 13:18:32 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Anson Huang <anson.huang@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        Leonard Crestez <leonard.crestez@....com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "Sven.Schmitt@...ed-mode.de" <Sven.Schmitt@...ed-mode.de>,
        "vivek.gautam@...eaurora.org" <vivek.gautam@...eaurora.org>,
        "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "robh@...nel.org" <robh@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource()
 to simplify code


On 4/1/2019 11:37 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh
> ---
>   drivers/soc/imx/gpc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index 7d14a4b..a8f1e47 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -406,7 +406,6 @@ static int imx_gpc_probe(struct platform_device *pdev)
>   	const struct imx_gpc_dt_data *of_id_data = of_id->data;
>   	struct device_node *pgc_node;
>   	struct regmap *regmap;
> -	struct resource *res;
>   	void __iomem *base;
>   	int ret;
>   
> @@ -417,8 +416,7 @@ static int imx_gpc_probe(struct platform_device *pdev)
>   	    !pgc_node)
>   		return 0;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(&pdev->dev, res);
> +	base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(base))
>   		return PTR_ERR(base);
>