linux-kernel - Re: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f45381e1-3509-af6b-b694-05788e6fa05f@codeaurora.org>
Date:   Mon, 1 Apr 2019 13:23:07 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Will Cunningham <wjcunningham7@...il.com>, abbotti@....co.uk
Cc:     hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style
 error.


On 4/1/2019 4:23 AM, Will Cunningham wrote:
> Removed unnecessary parentheses.`
Remove the extra character at the end.

Fix the above thing then you can take.

Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

>
> Signed-off-by: Will Cunningham <wjcunningham7@...il.com>
> ---
>   drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index 0af5315d4357..da5d53a288f7 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>   		pcl818_alloc_dma(dev, it->options[2]);
>   
>   	/* use 1MHz or 10MHz oscilator */
> -	if ((it->options[3] == 0) || (it->options[3] == 10))
> +	if (it->options[3] == 0 || it->options[3] == 10)
>   		osc_base = I8254_OSC_BASE_10MHZ;
>   	else
>   		osc_base = I8254_OSC_BASE_1MHZ;
> @@ -1026,7 +1026,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>   	devpriv->ns_min = board->ns_min;
>   	if (!board->is_818) {
>   		/* extended PCL718 to 100kHz DAC */
> -		if ((it->options[6] == 1) || (it->options[6] == 100))
> +		if (it->options[6] == 1 || it->options[6] == 100)
>   			devpriv->ns_min = 10000;
>   	}
>   
> @@ -1067,12 +1067,12 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>   		s->maxdata	= 0x0fff;
>   		s->range_table	= &range_unipolar5;
>   		if (board->is_818) {
> -			if ((it->options[4] == 1) || (it->options[4] == 10))
> +			if (it->options[4] == 1 || it->options[4] == 10)
>   				s->range_table = &range_unipolar10;
>   			if (it->options[4] == 2)
>   				s->range_table = &range_unknown;
>   		} else {
> -			if ((it->options[5] == 1) || (it->options[5] == 10))
> +			if (it->options[5] == 1 || it->options[5] == 10)
>   				s->range_table = &range_unipolar10;
>   			if (it->options[5] == 2)
>   				s->range_table = &range_unknown;