linux-kernel - Re: [PATCH] rtc: snvs: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a485ab9-435f-4dfc-1e3d-4dc97e95376a@codeaurora.org>
Date:   Mon, 1 Apr 2019 13:27:20 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Anson Huang <anson.huang@....com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] rtc: snvs: use devm_platform_ioremap_resource() to
 simplify code


On 4/1/2019 10:59 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
>   drivers/rtc/rtc-snvs.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c
> index ce73eab..e0edd594 100644
> --- a/drivers/rtc/rtc-snvs.c
> +++ b/drivers/rtc/rtc-snvs.c
> @@ -272,7 +272,6 @@ static const struct regmap_config snvs_rtc_config = {
>   static int snvs_rtc_probe(struct platform_device *pdev)
>   {
>   	struct snvs_rtc_data *data;
> -	struct resource *res;
>   	int ret;
>   	void __iomem *mmio;
>   
> @@ -284,9 +283,8 @@ static int snvs_rtc_probe(struct platform_device *pdev)
>   
>   	if (IS_ERR(data->regmap)) {
>   		dev_warn(&pdev->dev, "snvs rtc: you use old dts file, please update it\n");
> -		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>   
Remove this blank line.

Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

> -		mmio = devm_ioremap_resource(&pdev->dev, res);
> +		mmio = devm_platform_ioremap_resource(pdev, 0);
>   		if (IS_ERR(mmio))
>   			return PTR_ERR(mmio);
>