linux-kernel - Re: [PATCH] pwm: imx27: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fae9beb-1dbc-5e62-a39e-57ae5d8e7671@codeaurora.org>
Date:   Mon, 1 Apr 2019 13:31:05 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Anson Huang <anson.huang@....com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to
 simplify code


On 4/1/2019 10:54 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>


Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/pwm/pwm-imx27.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
> index 8061306..434a351 100644
> --- a/drivers/pwm/pwm-imx27.c
> +++ b/drivers/pwm/pwm-imx27.c
> @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
>   static int pwm_imx27_probe(struct platform_device *pdev)
>   {
>   	struct pwm_imx27_chip *imx;
> -	struct resource *r;
>   
>   	imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
>   	if (imx == NULL)
> @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
>   	imx->chip.of_xlate = of_pwm_xlate_with_flags;
>   	imx->chip.of_pwm_n_cells = 3;
>   
> -	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
> +	imx->mmio_base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(imx->mmio_base))
>   		return PTR_ERR(imx->mmio_base);
>