linux-kernel - Re: [PATCH] gpio: mxc: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ce7c8e36-39d0-efef-eb0c-d403d8eb8801@codeaurora.org>
Date:   Mon, 1 Apr 2019 13:41:16 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Anson Huang <anson.huang@....com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to
 simplify code


On 4/1/2019 10:39 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/gpio/gpio-mxc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index e86e61d..b281358 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -411,7 +411,6 @@ static int mxc_gpio_probe(struct platform_device *pdev)
>   {
>   	struct device_node *np = pdev->dev.of_node;
>   	struct mxc_gpio_port *port;
> -	struct resource *iores;
>   	int irq_base;
>   	int err;
>   
> @@ -423,8 +422,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
>   
>   	port->dev = &pdev->dev;
>   
> -	iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	port->base = devm_ioremap_resource(&pdev->dev, iores);
> +	port->base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(port->base))
>   		return PTR_ERR(port->base);
>