linux-kernel - Re: [PATCH] pinctrl: freescale: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1acb40f-bc90-3241-0a6b-f26f6abe4f0c@codeaurora.org>
Date:   Mon, 1 Apr 2019 13:41:55 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Anson Huang <anson.huang@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "festevam@...il.com" <festevam@...il.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] pinctrl: freescale: use devm_platform_ioremap_resource()
 to simplify code


On 4/1/2019 10:37 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/pinctrl/freescale/pinctrl-imx.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 188001b..cc6f5cc 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -785,7 +785,6 @@ int imx_pinctrl_probe(struct platform_device *pdev,
>   	struct pinctrl_desc *imx_pinctrl_desc;
>   	struct device_node *np;
>   	struct imx_pinctrl *ipctl;
> -	struct resource *res;
>   	struct regmap *gpr;
>   	int ret, i;
>   
> @@ -817,8 +816,7 @@ int imx_pinctrl_probe(struct platform_device *pdev,
>   			ipctl->pin_regs[i].conf_reg = -1;
>   		}
>   
> -		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -		ipctl->base = devm_ioremap_resource(&pdev->dev, res);
> +		ipctl->base = devm_platform_ioremap_resource(pdev, 0);
>   		if (IS_ERR(ipctl->base))
>   			return PTR_ERR(ipctl->base);
>