linux-kernel - Re: [PATCH 3/3] nvmem: imx-iim: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38642905-7084-0395-54a6-f76507badfcf@codeaurora.org>
Date:   Mon, 1 Apr 2019 13:44:26 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Anson Huang <anson.huang@....com>,
        "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 3/3] nvmem: imx-iim: use devm_platform_ioremap_resource()
 to simplify code


On 4/1/2019 10:29 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/nvmem/imx-iim.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/nvmem/imx-iim.c b/drivers/nvmem/imx-iim.c
> index 6651e4c..3458229 100644
> --- a/drivers/nvmem/imx-iim.c
> +++ b/drivers/nvmem/imx-iim.c
> @@ -104,7 +104,6 @@ static int imx_iim_probe(struct platform_device *pdev)
>   {
>   	const struct of_device_id *of_id;
>   	struct device *dev = &pdev->dev;
> -	struct resource *res;
>   	struct iim_priv *iim;
>   	struct nvmem_device *nvmem;
>   	struct nvmem_config cfg = {};
> @@ -114,8 +113,7 @@ static int imx_iim_probe(struct platform_device *pdev)
>   	if (!iim)
>   		return -ENOMEM;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	iim->base = devm_ioremap_resource(dev, res);
> +	iim->base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(iim->base))
>   		return PTR_ERR(iim->base);
>