linux-kernel - RE: [RFC] ARM: dts: imx: Fix the AR803X phy-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Apr 2019 08:38:28 +0000
From:   Steve Twiss <stwiss.opensource@...semi.com>
To:     Fabio Estevam <festevam@...il.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     PENGUTRONIX <kernel@...gutronix.de>, IMXNXP <linux-imx@....com>,
        "smoch@....de" <smoch@....de>, ARMLINUX <linux@...linux.org.uk>,
        "andrew@...n.ch" <andrew@...n.ch>,
        LINUX-ARM-KERNEL <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Support Opensource <Support.Opensource@...semi.com>,
        Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Subject: RE: [RFC] ARM: dts: imx: Fix the AR803X phy-mode

Hi Fabio,

On 30 March 2019 15:51 Fabio Estevam, wrote:

> Subject: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
> 
> Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> exposed an issue on imx DTS files using AR8031/AR8035 PHYs.
> 
> The end result is that the boards can no longer obtain an IP address
> via UDHCP, for example.

[...]

>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi   | 2 +-

[...]

> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index a0705066ccba..185fb17a3500 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -202,7 +202,7 @@
>  &fec {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_enet>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>  	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
>  	status = "okay";
>  };

[...]

This patch looks surprisingly similar to this one ;)
https://lore.kernel.org/patchwork/patch/1052588/

Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazzoni@free-electrons.com
Tested-by: Steve Twiss <stwiss.opensource@...semi.com>
Tested-by: Adam Thomson <Adam.Thomson@...semi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@...semi.com>

Regards,
Steve