linux-kernel - Re: [PATCH] drm/stm: ltdc: disable hw interrupts before its handler init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d63b7a3e-3162-7823-fa42-81a1aeccb5ff@st.com>
Date:   Mon, 1 Apr 2019 09:18:53 +0000
From:   Philippe CORNU <philippe.cornu@...com>
To:     Yannick FERTRE <yannick.fertre@...com>,
        Vincent ABRIOU <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        "Alexandre TORGUE" <alexandre.torgue@...com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/stm: ltdc: disable hw interrupts before its handler
 init


On 3/29/19 4:48 PM, Yannick Fertré wrote:
> Interrupt register must be disabled before call of
> devm_request_threaded_irq function to avoid dummy interruption.
> 
> Signed-off-by: Yannick Fertré <yannick.fertre@...com>
> ---
>   drivers/gpu/drm/stm/ltdc.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index b1741a9..ef5b4d6 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1118,6 +1118,10 @@ int ltdc_load(struct drm_device *ddev)
>   		goto err;
>   	}
>   
> +	/* Disable interrupts */
> +	reg_clear(ldev->regs, LTDC_IER,
> +		  IER_LIE | IER_RRIE | IER_FUIE | IER_TERRIE);
> +
>   	for (i = 0; i < MAX_IRQ; i++) {
>   		irq = platform_get_irq(pdev, i);
>   		if (irq < 0)
> @@ -1138,10 +1142,6 @@ int ltdc_load(struct drm_device *ddev)
>   		reset_control_deassert(rstc);
>   	}
>   
> -	/* Disable interrupts */
> -	reg_clear(ldev->regs, LTDC_IER,
> -		  IER_LIE | IER_RRIE | IER_FUIE | IER_TERRIE);
> -

Dear Yannick,
Thank you for your patch,

Acked-by: Philippe Cornu <philippe.cornu@...com>

Philippe :-)

>   	ret = ltdc_get_caps(ddev);
>   	if (ret) {
>   		DRM_ERROR("hardware identifier (0x%08x) not supported!\n",
>