linux-kernel - Re: [PATCH] mfd: cros: Update EC protocol to match current EC code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190401100659.GA4187@dell>
Date:   Mon, 1 Apr 2019 11:06:59 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Gwendal Grignou <gwendal@...omium.org>
Cc:     groeck@...omium.org, enric.balletbo@...labora.com,
        bleung@...omium.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: cros: Update EC protocol to match current EC code

On Wed, 27 Feb 2019, Gwendal Grignou wrote:

> Chromebook Embedded Controller protocol is defined in the kernel at
> cros_ec_commands.h.
> The source of trust for the EC protocol is at
> https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h
> 
> Only needed changes have been picked up from this file to the kernel
> include file leading to gaps between the upstream version and what the
> latest ECs can do.
> 
> Fill the gaps to ease future integrations. Changes from the original
> files is header/footer for license and include files for alignment.
> 
> Check this include file works on ChomeOS kernel 4.14 and 4.19 on eve.
> 
> Signed-off-by: Gwendal Grignou <gwendal@...omium.org>
> ---
>  include/linux/mfd/cros_ec_commands.h | 3627 +++++++++++++++++++++-----
>  1 file changed, 2935 insertions(+), 692 deletions(-)

I'm pretty lost as to what's happening with this set now.

Once you have corrected all of the patch formatting issues and
collected all of the Acks to-date, could you please re-submit as a
new/clean patch-set please?

Just to clarify, please don't reply-to, as this can get out of hand
very quickly.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog