linux-kernel - Re: [PATCH] max98357a:add dai without triggered by pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190401032446.GC2059@sirena.org.uk>
Date:   Mon, 1 Apr 2019 10:24:46 +0700
From:   Mark Brown <broonie@...nel.org>
To:     tony.zou.hq@...il.com
Cc:     alsa-devel@...a-project.org, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, linux-kernel@...r.kernel.org,
        dbasehore@...omium.org,
        Tony Zou <zoutao@...qin.corp-partner.google.com>
Subject: Re: [PATCH] max98357a:add dai without triggered by pcm

On Fri, Mar 29, 2019 at 09:51:59AM +0800, tony.zou.hq@...il.com wrote:

> max98357a's enable pin need setting independently
> when max98357a is shared I2S with other codec.

> add dai "max98357a-hifi" without pcm trigger,
> and use "Spk PA Switch" to set the enable pin.

This sounds like a really bad idea - if you have multiple CODECs on a
single DAI link tell the core about it, don't try to bodge around it.
There's support for multiple CODECs on a DAI link already.

> +static const char * const ext_spk_text[] = {
> +	"Off", "On"
> +};

Simple on/off switches should be normal switch controls, not enums.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)