linux-kernel - Re: [RFC PATCH] i2c: remove use of in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190401115414.hxrqqjujvwczdafz@ninjato>
Date:   Mon, 1 Apr 2019 13:54:14 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-i2c@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Frederic Weisbecker <fweisbec@...il.com>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH] i2c: remove use of in_atomic()

> > "This matches the use cases for atomic I2C transfers I have seen so far:
> > very late communication (mostly to a PMIC) to powerdown or reboot the
> > system."
> 
> Ah, sorry, I missed that.
> 
> > And yes, I would never recommend a HW design to use I2C for shutting
> > down/rebooting. But such HW is out there.
> 
> Can we then make the whole thing conditional on:
> 
>   system_state > SYSTEM_RUNNING
> 
> Such that we're sure to never trigger this under any other conditions?

Oh, we can for sure modify the code to something else. Actually, this is
why I was calling out to you. I was never comfortable with the old
'in_atomic() || irqs_disabled()' code, but wasn't sure what would be an
adequate replacement which will not risk regressions.

The above condition makes much more sense to me and is also much more
readable. Can it simply replace irqs_disabled()? Are interrupts already
disabled for system_state > SYSTEM_RUNNING? (I got a bit lost in the
code paths when trying to figure it out)

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)