linux-kernel - Re: [PATCH 3/4] ARM: dts: dra7: add PRU-ICSS modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190401143036.GF49658@atomide.com>
Date:   Mon, 1 Apr 2019 07:30:37 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Roger Quadros <rogerq@...com>
Cc:     s-anna@...com, nsekhar@...com, linux-omap@...r.kernel.org,
        t-kristo@...com, nsaulnier@...com, jreeder@...com,
        m-karicheri2@...com, david@...hnology.com,
        woods.technical@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] ARM: dts: dra7: add PRU-ICSS modules

* Roger Quadros <rogerq@...com> [190329 14:02]:
> Hi Tony,
> 
> On 04/02/2019 20:03, Tony Lindgren wrote:
> > * Roger Quadros <rogerq@...com> [190204 15:54]:
> >> --- a/arch/arm/boot/dts/dra7.dtsi
> >> +++ b/arch/arm/boot/dts/dra7.dtsi
> >> @@ -167,6 +167,200 @@
> >>  		l4_per3: interconnect@...00000 {
> >>  		};
> >>  
> >> +		pru_icss1: target-module@...00000 {
> > 
> > I suggest you add these into dra7-pruss.dtsi as they
> > have internal interconnects. And eventually some of
> > the *pruss.dtsi files might become shared :) And we
> > avoid moving these around when we define the l3
> > interconnects and avoid a lot of extra long dtsi
> > line lengths with the added nestedness later on.
> 
> PRUSS is only present on AM57x variants.
> I will move this to am57x-pruss.dtsi.
> 
> This means all AM57x boards will have to include it.
> 
> Is this OK?

Sure sounds good to me.

Regards,

Tony