linux-kernel - Re: [PATCH] arm64: mm: fix max_mapnr is assigned the wrong value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 Apr 2019 15:32:41 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Muchun Song <smuchun@...il.com>
Cc:     will.deacon@....com, akpm@...ux-foundation.org,
        rppt@...ux.vnet.ibm.com,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>, logang@...tatee.com,
        robin.murphy@....com, ghackmann@...roid.com, hannes@...xchg.org,
        stefan@...er.ch, david@...hat.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: mm: fix max_mapnr is assigned the wrong value

On Mon, Apr 01, 2019 at 10:21:58PM +0800, Muchun Song wrote:
> Thanks for your reply.  In fact, I didn't hit any problem.  I just read the code
> and found the problem. I see max_mapnr is to only be used in the
> generic pfn_valid().
> As you said, we do not use it on arm64.  So in a sense, the patch is
> meaningless.
> 
> But I think since it is a problem, why not fix it (Even if max_mapnr
> is not be used)?
> What is your opinion?

I'm ok with fixing, only that it's not urgent. Will can pick it up for
the 5.2 merging window.

Reviewed-by: Catalin Marinas <catalin.marinas@....com>