linux-kernel - Re: [PATCH v2] usb: host: xhci: Support running urb giveback in tasklet context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1904011040570.1506-100000@iolanthe.rowland.org>
Date:   Mon, 1 Apr 2019 10:43:24 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Suwan Kim <suwan.kim027@...il.com>
cc:     mathias.nyman@...ux.intel.com, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2] usb: host: xhci: Support running urb giveback in
 tasklet context

On Mon, 1 Apr 2019, Suwan Kim wrote:

> Patch "USB: HCD: support giveback of URB in tasklet context"[1]
> introduced giveback of urb in tasklet context. [1] This patch was
> applied to ehci but not xhci. [2] This patch significantly reduces
> the hard irq time of xhci. Especially for uvc driver, the hard irq
> including the uvc completion function runs quite long but applying
> this patch reduces the hard irq time of xhci.

Please read the kerneldoc for usb_submit_urb() and usb_kill_urb(), in 
particular, the parts that describe how isochronous URBs are treated.  
Can you guarantee that with this patch applied, xhci-hcd will continue 
to work as the kerneldoc describes?

Alan Stern