linux-kernel - Re: [PATCH] i2c: isch: Remove unnecessary acpi.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1554131240.6965.5.camel@suse.de>
Date:   Mon, 01 Apr 2019 17:07:20 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mukesh Ojha <mojha@...eaurora.org>,
        Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH] i2c: isch: Remove unnecessary acpi.h include

Hi Bjorn,

On Mon, 2019-04-01 at 08:50 -0500, Bjorn Helgaas wrote:
> On Mon, Mar 25, 2019 at 1:37 PM <helgaas@...nel.org> wrote:
> > 
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > 
> > 54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included
> > <linux/acpi.h> so we could use acpi_check_region().  fd46a0064af1 ("i2c:
> > convert i2c-isch to platform_device") removed the use of
> > acpi_check_region() but not the include.
> > 
> > Remove the now-unnecessary include of <linux/acpi.h>.  No functional change
> > intended.
> > 
> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Added
> 
>     Fixes: fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
>     Reviewed-by: Jean Delvare <jdelvare@...e.de>
>     Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>
> 
> on my local branch.
> 
> Jean, would you like me to repost this with the updates?  I assume you
> will merge this (just based on get_maintainer.pl)?

No, Wolfram prefers to pick all the i2c patches into his own branch,
I'm only giving my Reviewed-by. So your question is for him.

Thanks,
-- 
Jean Delvare
SUSE L3 Support