linux-kernel - Re: [PATCH 10/17] delta: Fix buffer overrun in delta_ipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190401165400.pdp547zqwdojz67r@two.firstfloor.org>
Date:   Mon, 1 Apr 2019 09:54:01 -0700
From:   Andi Kleen <andi@...stfloor.org>
To:     Hugues FRUCHET <hugues.fruchet@...com>
Cc:     Andi Kleen <andi@...stfloor.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        "mchehab@...pensource.com" <mchehab@...pensource.com>
Subject: Re: [PATCH 10/17] delta: Fix buffer overrun in delta_ipc_open

On Mon, Apr 01, 2019 at 01:37:56PM +0000, Hugues FRUCHET wrote:
> Hi Andi,
> 
> We have already discussed about that here:
> https://lore.kernel.org/patchwork/patch/866406/
> 
> Now that strscpy is largely deployed within kernel, could you retest 
> with the change I suggested ?

strscpy is not the correct fix because it leaks uninitialized memory
to the receiver.  You need the memset.

-Andi