lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 31 Mar 2019 21:25:44 -0700 From: Andrey Smirnov <andrew.smirnov@...il.com> To: linux-pci@...r.kernel.org Cc: Andrey Smirnov <andrew.smirnov@...il.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Bjorn Helgaas <bhelgaas@...gle.com>, Fabio Estevam <fabio.estevam@....com>, Chris Healy <cphealy@...il.com>, Lucas Stach <l.stach@...gutronix.de>, Leonard Crestez <leonard.crestez@....com>, "A.s. Dong" <aisheng.dong@....com>, Richard Zhu <hongxing.zhu@....com>, linux-imx@....com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: [PATCH v3 08/11] PCI: imx6: Simplify pcie_phy_poll_ack() Simplify pcie_phy_poll_ack() by incorporating shifting into constant definition and convert the code to use 'bool'. No functional change intended. Cc: Lorenzo Pieralisi <lorenzo.pieralisi@....com> Cc: Bjorn Helgaas <bhelgaas@...gle.com> Cc: Fabio Estevam <fabio.estevam@....com> Cc: Chris Healy <cphealy@...il.com> Cc: Lucas Stach <l.stach@...gutronix.de> Cc: Leonard Crestez <leonard.crestez@....com> Cc: "A.s. Dong" <aisheng.dong@....com> Cc: Richard Zhu <hongxing.zhu@....com> Cc: linux-imx@....com Cc: linux-arm-kernel@...ts.infradead.org Cc: linux-kernel@...r.kernel.org Cc: linux-pci@...r.kernel.org Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com> --- drivers/pci/controller/dwc/pci-imx6.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index a49e5e491e12..7c3ffb751002 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -112,7 +112,7 @@ struct imx6_pcie { #define PCIE_PHY_CTRL_RD BIT(19) #define PCIE_PHY_STAT (PL_OFFSET + 0x110) -#define PCIE_PHY_STAT_ACK_LOC 16 +#define PCIE_PHY_STAT_ACK BIT(16) #define PCIE_LINK_WIDTH_SPEED_CONTROL 0x80C @@ -151,16 +151,16 @@ struct imx6_pcie { #define PHY_RX_OVRD_IN_LO_RX_DATA_EN BIT(5) #define PHY_RX_OVRD_IN_LO_RX_PLL_EN BIT(3) -static int pcie_phy_poll_ack(struct imx6_pcie *imx6_pcie, int exp_val) +static int pcie_phy_poll_ack(struct imx6_pcie *imx6_pcie, bool exp_val) { struct dw_pcie *pci = imx6_pcie->pci; - u32 val; + bool val; u32 max_iterations = 10; u32 wait_counter = 0; do { - val = dw_pcie_readl_dbi(pci, PCIE_PHY_STAT); - val = (val >> PCIE_PHY_STAT_ACK_LOC) & 0x1; + val = dw_pcie_readl_dbi(pci, PCIE_PHY_STAT) & + PCIE_PHY_STAT_ACK; wait_counter++; if (val == exp_val) -- 2.20.1
Powered by blists - more mailing lists