lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190401013554.17488-1-yuehaibing@huawei.com> Date: Mon, 1 Apr 2019 09:35:54 +0800 From: Yue Haibing <yuehaibing@...wei.com> To: <davem@...emloft.net>, <gerrit@....abdn.ac.uk> CC: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <dccp@...r.kernel.org>, <mojha@...eaurora.org>, YueHaibing <yuehaibing@...wei.com> Subject: [PATCH] dccp: Fix memleak in __feat_register_sp From: YueHaibing <yuehaibing@...wei.com> If dccp_feat_push_change fails, we forget free the mem which is alloced by kmemdup in dccp_feat_clone_sp_val. Reported-by: Hulk Robot <hulkci@...wei.com> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values") Reviewed-by: Mukesh Ojha <mojha@...eaurora.org> Signed-off-by: YueHaibing <yuehaibing@...wei.com> --- net/dccp/feat.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/dccp/feat.c b/net/dccp/feat.c index f227f00..db87d9f 100644 --- a/net/dccp/feat.c +++ b/net/dccp/feat.c @@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local, if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len)) return -ENOMEM; - return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval); + if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) { + kfree(fval.sp.vec); + return -ENOMEM; + } + + return 0; } /** -- 2.7.4
Powered by blists - more mailing lists